remove publishing gulp tasks

moves changes made in 0b47cf79c1 to the mapclick processing for benefit of other mapclick calls

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2020-2025 Matt Walsh
+Copyright (c) 2020-2026 Matt Walsh
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

gulp/build.mjs

@@ -8,18 +8,14 @@ import ejs from 'gulp-ejs';
 import rename from 'gulp-rename';
 import htmlmin from 'gulp-html-minifier-terser';
 import { deleteAsync } from 'del';
-import s3Upload from 'gulp-s3-uploader';
 import webpack from 'webpack-stream';
 import TerserPlugin from 'terser-webpack-plugin';
 import { readFile } from 'fs/promises';
 import file from 'gulp-file';
-import { CloudFrontClient, CreateInvalidationCommand } from '@aws-sdk/client-cloudfront';
-import log from 'fancy-log';
 import * as dartSass from 'sass';
 import gulpSass from 'gulp-sass';
-import sourceMaps from 'gulp-sourcemaps';
+import log from 'fancy-log';
 import OVERRIDES from '../src/overrides.mjs';
-import { DateTime } from 'luxon';
 
 // get cloudfront
 import reader from '../src/playlist-reader.mjs';
@@ -28,8 +24,6 @@ const sass = gulpSass(dartSass);
 
 const clean = () => deleteAsync(['./dist/**/*', '!./dist/readme.txt']);
 
-const cloudfront = new CloudFrontClient({ region: 'us-east-1' });
-
 const RESOURCES_PATH = './dist/resources';
 
 // Data is now served as JSON files to avoid redundancy
@@ -37,12 +31,55 @@ const RESOURCES_PATH = './dist/resources';
 const webpackOptions = {
 	mode: 'production',
 	output: {
-		filename: 'ws.min.js',
+		filename: '[name].min.js',
 	},
 	resolve: {
 		roots: ['./'],
 	},
 	devtool: 'source-map',
+	entry: {
+		index: {
+			import: './server/scripts/index.mjs',
+			dependOn: 'shared',
+		},
+		displays: {
+			import: [
+				'./server/scripts/modules/hazards.mjs',
+				'./server/scripts/modules/currentweather.mjs',
+				'./server/scripts/modules/almanac.mjs',
+				'./server/scripts/modules/spc-outlook.mjs',
+				'./server/scripts/modules/extendedforecast.mjs',
+				'./server/scripts/modules/hourly.mjs',
+				'./server/scripts/modules/hourly-graph.mjs',
+				'./server/scripts/modules/latestobservations.mjs',
+				'./server/scripts/modules/localforecast.mjs',
+				'./server/scripts/modules/radar.mjs',
+				'./server/scripts/modules/regionalforecast.mjs',
+				'./server/scripts/modules/travelforecast.mjs',
+			],
+			dependOn: 'shared',
+		},
+		features: {
+			import: [
+				'./server/scripts/modules/custom-scroll-text.mjs',
+				'./server/scripts/modules/currentweatherscroll.mjs',
+				'./server/scripts/modules/media.mjs',
+			],
+			dependOn: 'shared',
+		},
+		shared: [
+			'./server/scripts/modules/progress.mjs',
+			'./server/scripts/modules/settings.mjs',
+			'./server/scripts/modules/utils/setting.mjs',
+			'./server/scripts/modules/icons.mjs',
+			'./server/scripts/modules/utils/cache.mjs',
+			'./server/scripts/modules/utils/debug.mjs',
+			'./server/scripts/modules/utils/image.mjs',
+			'./server/scripts/modules/utils/metar.mjs',
+			'./server/scripts/modules/utils/mapclick.mjs',
+			'./server/scripts/modules/utils/units.mjs',
+		],
+	},
 	optimization: {
 		minimize: true,
 		minimizer: [
@@ -60,7 +97,6 @@ const webpackOptions = {
 };
 
 const jsVendorSources = [
-	'server/scripts/vendor/auto/nosleep.js',
 	'server/scripts/vendor/auto/swiped-events.js',
 	'server/scripts/vendor/auto/suncalc.js',
 ];
@@ -98,35 +134,36 @@ const buildJs = () => src(mjsSources)
 const cssSources = [
 	'server/styles/scss/**/*.scss',
 ];
-const buildCss = () => src(cssSources)
-	.pipe(sourceMaps.init())
+const buildCss = () => src(cssSources, { sourcemaps: true })
 	.pipe(sass({ style: 'compressed' }).on('error', sass.logError))
 	.pipe(rename({ suffix: '.min' }))
-	.pipe(sourceMaps.write('./'))
-	.pipe(dest(RESOURCES_PATH));
+	.pipe(dest(RESOURCES_PATH, { sourcemaps: '.' }));
 
 const htmlSources = [
 	'views/*.ejs',
 ];
-const packageJson = await readFile('package.json');
-let { version } = JSON.parse(packageJson);
-const previewVersion = async () => {
-	// generate a unique timestamp for cache invalidation of the preview site
-	const now = DateTime.utc();
-	version = now.toFormat('yyyyLLddHHmm').substring(3);
+
+const getVersion = async () => {
+	const packageJson = await readFile('package.json');
+	const packageVersion = JSON.parse(packageJson).version;
+
+	return process.env.WS4KP_VERSION ?? packageVersion;
 };
 
-const compressHtml = async () => src(htmlSources)
-	.pipe(ejs({
-		production: version,
-		serverAvailable: false,
-		version,
-		OVERRIDES,
-		query: {},
-	}))
-	.pipe(rename({ extname: '.html' }))
-	.pipe(htmlmin({ collapseWhitespace: true }))
-	.pipe(dest('./dist'));
+const compressHtml = async () => {
+	const version = await getVersion();
+	return src(htmlSources)
+		.pipe(ejs({
+			production: version,
+			serverAvailable: false,
+			version,
+			OVERRIDES,
+			query: {},
+		}))
+		.pipe(rename({ extname: '.html' }))
+		.pipe(htmlmin({ collapseWhitespace: true }))
+		.pipe(dest('./dist'));
+};
 
 const otherFiles = [
 	'server/robots.txt',
@@ -143,70 +180,15 @@ const copyDataFiles = () => src([
 	'datagenerators/output/stations.json',
 ]).pipe(dest('./dist/data'));
 
-const s3 = s3Upload({
-	useIAM: true,
-}, {
-	region: 'us-east-1',
-});
-const uploadSources = [
-	'dist/**',
-	'!dist/images/**/*',
-	'!dist/fonts/**/*',
-];
-
-const uploadCreator = (bucket) => () => src(uploadSources, { base: './dist', encoding: false })
-	.pipe(s3({
-		Bucket: bucket,
-		StorageClass: 'STANDARD',
-		maps: {
-			CacheControl: (keyname) => {
-				if (keyname.indexOf('index.html') > -1) return 'max-age=300'; // 10 minutes
-				if (keyname.indexOf('.mp3') > -1) return 'max-age=31536000'; // 1 year for mp3 files
-				return 'max-age=2592000'; // 1 month
-			},
-		},
-	}));
-
 const imageSources = [
 	'server/fonts/**',
 	'server/images/**',
 	'!server/images/gimp/**',
 ];
 
-const upload = uploadCreator(process.env.BUCKET);
-const uploadPreview = uploadCreator(process.env.BUCKET_PREVIEW);
-
-const uploadImagesCreator = (bucket) => () => src(imageSources, { base: './server', encoding: false })
-	.pipe(
-		s3({
-			Bucket: bucket,
-			StorageClass: 'STANDARD',
-			maps: {
-				CacheControl: () => 'max-age=31536000',
-			},
-		}),
-	);
-
-const uploadImages = uploadImagesCreator(process.env.BUCKET);
-const uploadImagesPreview = uploadImagesCreator(process.env.BUCKET_PREVIEW);
-
 const copyImageSources = () => src(imageSources, { base: './server', encoding: false })
 	.pipe(dest('./dist'));
 
-const invalidateCreator = (distributionId) => () => cloudfront.send(new CreateInvalidationCommand({
-	DistributionId: distributionId,
-	InvalidationBatch: {
-		CallerReference: (new Date()).toLocaleString(),
-		Paths: {
-			Quantity: 1,
-			Items: ['/*'],
-		},
-	},
-}));
-
-const invalidate = invalidateCreator(process.env.DISTRIBUTION_ID);
-const invalidatePreview = invalidateCreator(process.env.DISTRIBUTION_ID_PREVIEW);
-
 const buildPlaylist = async () => {
 	const availableFiles = await reader();
 	const playlist = { availableFiles };
@@ -214,20 +196,13 @@ const buildPlaylist = async () => {
 };
 
 const logVersion = async () => {
-	log(`Version Published: ${version}`);
+	log(`Built version: ${await getVersion()}`);
 };
 
-const buildDist = series(clean, parallel(buildJs, compressJsVendor, buildCss, compressHtml, copyOtherFiles, copyDataFiles, copyImageSources, buildPlaylist));
+const buildDist = series(clean, parallel(buildJs, compressJsVendor, buildCss, compressHtml, copyOtherFiles, copyDataFiles, copyImageSources, buildPlaylist), logVersion);
 
-// upload_images could be in parallel with upload, but _images logs a lot and has little changes
-// by running upload last the majority of the changes will be at the bottom of the log for easy viewing
-const publishFrontend = series(buildDist, uploadImages, upload, invalidate, logVersion);
-const stageFrontend = series(previewVersion, buildDist, uploadImagesPreview, uploadPreview, invalidatePreview, logVersion);
-
-export default publishFrontend;
+export default buildDist;
 
 export {
-	buildDist,
-	invalidate,
-	stageFrontend,
+	logVersion,
 };

gulp/update-vendor.mjs

@@ -7,7 +7,7 @@ const clean = () => deleteAsync(['./server/scripts/vendor/auto/**']);
 const vendorFiles = [
 	'./node_modules/luxon/build/es6/luxon.mjs',
 	'./node_modules/luxon/build/es6/luxon.mjs.map',
-	'./node_modules/nosleep.js/dist/NoSleep.js',
+	'./node_modules/@zakj/no-sleep/dist/no-sleep.js',
 	'./node_modules/suncalc/suncalc.js',
 	'./node_modules/swiped-events/src/swiped-events.js',
 ];

gulpfile.mjs

@@ -1,10 +1,7 @@
 import updateVendor from './gulp/update-vendor.mjs';
-import publishFrontend, { buildDist, invalidate, stageFrontend } from './gulp/publish-frontend.mjs';
+import buildDist from './gulp/build.mjs';
 
 export {
 	updateVendor,
-	publishFrontend,
 	buildDist,
-	invalidate,
-	stageFrontend,
 };

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "ws4kp",
-	"version": "6.5.7",
+	"version": "6.5.9",
 	"description": "Welcome to the WeatherStar 4000+ project page!",
 	"main": "index.mjs",
 	"type": "module",
@@ -27,38 +27,34 @@
 	},
 	"homepage": "https://github.com/netbymatt/ws4kp#readme",
 	"devDependencies": {
-		"@aws-sdk/client-cloudfront": "^3.609.0",
 		"@eslint/eslintrc": "^3.3.1",
+		"@zakj/no-sleep": "^0.13.6",
 		"ajv": "^8.17.1",
 		"del": "^8.0.0",
-		"eslint": "^10.0.3",
+		"eslint": "^9.0.0",
 		"eslint-config-airbnb-base": "15.0.0",
 		"eslint-plugin-import": "^2.10.0",
-		"fancy-log": "^2.0.0",
 		"gulp": "^5.0.0",
-		"gulp-awspublish": "^9.0.0",
 		"gulp-concat": "^2.6.1",
 		"gulp-ejs": "^5.1.0",
 		"gulp-file": "^0.4.0",
 		"gulp-html-minifier-terser": "^8.0.0",
 		"gulp-rename": "^2.0.0",
-		"gulp-s3-uploader": "^1.0.6",
 		"gulp-sass": "^6.0.0",
-		"gulp-sourcemaps": "^3.0.0",
 		"gulp-terser": "^2.0.0",
 		"luxon": "^3.0.0",
 		"metar-taf-parser": "^9.0.0",
-		"nosleep.js": "^0.12.0",
 		"sass": "^1.54.0",
 		"suncalc": "^1.8.0",
 		"swiped-events": "^1.1.4",
 		"terser-webpack-plugin": "^5.3.6",
 		"webpack": "^5.99.9",
-		"webpack-stream": "^7.0.0"
+		"webpack-stream": "^7.0.0",
+		"fancy-log": "^2.0.0"
 	},
 	"dependencies": {
 		"dotenv": "^17.0.1",
 		"ejs": "^5.0.1",
 		"express": "^5.1.0"
 	}
-}
+}

server/scripts/index.mjs

@@ -72,7 +72,7 @@ const init = async () => {
 	if (!navigator.geolocation) btnGetGps.style.display = 'none';
 
 	document.querySelector('#divTwc').addEventListener('mousemove', () => {
-		if (document.fullscreenElement) updateFullScreenNavigate();
+		if (document.fullscreenElement || settings.kiosk?.value) updateFullScreenNavigate();
 	});
 
 	document.querySelector('#btnGetLatLng').addEventListener('click', () => autoComplete.directFormSubmit());
@@ -384,7 +384,7 @@ const updateFullScreenNavigate = () => {
 	}
 
 	navigateFadeIntervalId = setTimeout(() => {
-		if (document.fullscreenElement) {
+		if (document.fullscreenElement || settings.kiosk?.value) {
 			divTwcBottom.classList.remove('visible');
 			divTwcBottom.classList.add('hidden');
 			document.querySelector('#divTwc').classList.add('no-cursor');

server/scripts/modules/currentweather.mjs

@@ -103,9 +103,8 @@ class CurrentWeather extends WeatherDisplay {
 				});
 
 				// copy enhanced data and restore the timestamp if it was overwritten by older data from mapclick
-				const { timestamp } = candidateObservation.features[0].properties;
+
 				candidateObservation.features[0].properties = enhancedResult.data;
-				candidateObservation.features[0].properties.timestamp = timestamp;
 
 				const { missingFields } = enhancedResult;
 				const missingRequired = missingFields.filter((fieldName) => {

server/scripts/modules/custom-scroll-text.mjs

@@ -17,7 +17,7 @@ const changeEnable = (newValue) => {
 		// hide the string entry
 		newDisplay = 'none';
 	}
-	const stringEntry = document.getElementById('settings-customText-label');
+	const stringEntry = document.getElementById('settings-customText-string');
 	if (stringEntry) {
 		stringEntry.style.display = newDisplay;
 	}

server/scripts/modules/localforecast.mjs

@@ -37,9 +37,9 @@ class LocalForecast extends WeatherDisplay {
 		// read each text
 		this.screenTexts = conditions.map((condition) => {
 			// process the text
-			let text = `${condition.DayName.toUpperCase()}...`;
+			let text = `${condition.DayName}...`;
 			const conditionText = condition.Text;
-			text += conditionText.toUpperCase().replace('...', ' ');
+			text += conditionText.replace('...', ' ');
 
 			return text;
 		});
@@ -257,7 +257,7 @@ const parse = (forecast, forecastUrl) => {
 
 	return activePeriods.slice(0, 6).map((text) => ({
 		// format day and text
-		DayName: text.name.toUpperCase(),
+		DayName: text.name,
 		Text: text.detailedForecast,
 	}));
 };

server/scripts/modules/settings.mjs

@@ -112,9 +112,11 @@ const kioskChange = (value) => {
 
 	if (value) {
 		body.classList.add('kiosk');
+		document.querySelector('#divTwc')?.classList.add('no-cursor');
 		window.dispatchEvent(new Event('resize'));
 	} else {
 		body.classList.remove('kiosk');
+		document.querySelector('#divTwc')?.classList.remove('no-cursor');
 		window.dispatchEvent(new Event('resize'));
 	}
 

server/scripts/modules/utils/mapclick.mjs

@@ -650,7 +650,7 @@ export const enhanceObservationWithMapClick = async (observationData, options =
 	}
 
 	return {
-		data: mapClickProps,
+		data: { ...mapClickProps, timestamp: observationData.timestamp },
 		wasImproved: true,
 		improvements,
 		missingFields: [...mapClickMissingRequired, ...mapClickMissingOptional],

server/scripts/modules/utils/nosleep.mjs

@@ -1,5 +1,7 @@
 // track state of nosleep locally to avoid a null case error
 // when nosleep.disable is called without first calling .enable
+// eslint-disable-next-line import/extensions
+import NoSleep from '../../vendor/auto/no-sleep.js';
 
 let wakeLock = false;
 

server/styles/scss/_hazards.scss

@@ -4,6 +4,7 @@
 
 #hazards-html.weather-display {
 	background-image: url('../images/backgrounds/7.png');
+
 }
 
 .weather-display .main.hazards {
@@ -12,6 +13,11 @@
 		height: p.$standard-height;
 		background-color: rgb(112, 35, 35);
 
+		width: p.$standard-width;
+
+		.wide.enhanced & {
+			left: 0px;
+		}
 
 		.hazard-lines {
 			min-height: 400px;

server/styles/scss/_latest-observations.scss

@@ -32,6 +32,12 @@
 					display: inline-block;
 				}
 			}
+
+			.like {
+				display: none;
+			}
+
+
 		}
 
 		.temp {
@@ -58,7 +64,7 @@
 
 			.like {
 				left: 380px;
-				display: hidden;
+				display: block;
 
 				&.heat-index {
 					color: c.$heat-index;

server/styles/scss/_local-forecast.scss

@@ -25,7 +25,6 @@
 	.forecast {
 		font-family: 'Star4000';
 		font-size: 24pt;
-		text-transform: uppercase;
 		@include u.text-shadow();
 		min-height: 280px;
 		line-height: 40px;

server/styles/scss/_page.scss

@@ -825,4 +825,19 @@ body.kiosk #loading .instructions {
 	display: grid;
 	grid-template-columns: 1fr 1fr;
 	max-width: 250px;
+}
+
+.lower-flex-container {
+	display: flex;
+	flex-direction: row;
+	flex-wrap: wrap;
+	justify-content: flex-start;
+	align-items: flex-start;
+	align-content: stretch;
+	gap: 8px;
+	column-gap: 64px;
+
+	.item {
+		display: inline-block;
+	}
 }

server/styles/scss/_weather-display.scss

@@ -168,6 +168,21 @@
 	// adjust for wide
 	.wide & {
 		left: p.$wide-margin;
+		width: p.$wide-width;
+		margin-left: -1*p.$wide-margin;
+
+		.scroll-container {
+			margin-left: p.$wide-margin;
+		}
+
+	}
+
+	.wide.enhanced & {
+
+		&:has(.scroll-area) .scroll-container {
+			width: p.$wide-width;
+			margin-left: 0px;
+		}
 	}
 
 	&.hazard {
@@ -208,13 +223,4 @@
 
 
 
-}
-
-.wide #container>.scroll {
-	width: p.$wide-width;
-	margin-left: -1*p.$wide-margin;
-
-	.scroll-container {
-		margin-left: p.$wide-margin;
-	}
 }

views/index.ejs

@@ -31,7 +31,10 @@
   <% if (production) { %>
   <link rel="stylesheet" type="text/css" href="resources/ws.min.css?_=<%=production%>" />
   <script type="text/javascript" src="resources/vendor.min.js?_=<%=production%>"></script>
-  <script type="text/javascript" src="resources/ws.min.js?_=<%=production%>"></script>
+  <script type="text/javascript" src="resources/index.min.js?_=<%=production%>"></script>
+  <script type="text/javascript" src="resources/displays.min.js?_=<%=production%>"></script>
+  <script type="text/javascript" src="resources/features.min.js?_=<%=production%>"></script>
+  <script type="text/javascript" src="resources/shared.min.js?_=<%=production%>"></script>
   <script type="text/javascript">
     const OVERRIDES = <%- JSON.stringify(OVERRIDES ?? {}) %>;
   </script>
@@ -41,7 +44,6 @@
   <script type="text/javascript">
     OVERRIDES = <%- JSON.stringify(OVERRIDES ?? {}) %>;
   </script>
-  <script type="text/javascript" src="scripts/vendor/auto/nosleep.js"></script>
   <script type="text/javascript" src="scripts/vendor/auto/swiped-events.js"></script>
   <script type="text/javascript" src="scripts/vendor/auto/suncalc.js"></script>
   <script type="module" src="scripts/modules/hazards.mjs"></script>
@@ -174,21 +176,25 @@
     </div>
     <div class="media"></div>
 
-    <div class='heading'>Selected displays</div>
-    <div id='enabledDisplays'>
+    <div class='lower-flex-container'>
+      <div class='item'>
+        <div class='heading'>Selected displays</div>
+        <div id='enabledDisplays'>
 
-    </div>
-
-    <div class='heading'>Settings</div>
-    <div id='settings'>
-    </div>
-
-    <div class='heading'>Sharing</div>
-    <div class='info'>
-      <a href='' id='share-link'>Copy Permalink</a> <span id="share-link-copied">Link copied to clipboard!</span>
-      <div id="share-link-instructions">
-        Copy this long URL:
-        <input type='text' id="share-link-url">
+        </div>
+      </div>
+      <div class='item'>
+        <div class='heading'>Settings</div>
+        <div id='settings'>
+          <div class='heading'>Sharing</div>
+        </div>
+        <div class='item'>
+          <a href='' id='share-link'>Copy Permalink</a> <span id="share-link-copied">Link copied to clipboard!</span>
+          <div id="share-link-instructions">
+            Copy this long URL:
+            <input type='text' id="share-link-url">
+          </div>
+        </div>
       </div>
     </div>
 
@@ -211,7 +217,6 @@
       <div class="header">Ws4kp Version:</div>
       <div class="header"><span><%- version %></span></div>
     </div>
-  </div>
 
 </body>
 

views/partials/hazards.ejs

@@ -1,7 +1,7 @@
-	<div class="main hazards no-header">
-		<div class="hazard-lines">
-			<div class="hazard template">
-				<div class="hazard-text"></div>
-			</div>
-		</div>
+	<div class="main hazards no-header can-enhance">
+	  <div class="hazard-lines">
+	    <div class="hazard template">
+	      <div class="hazard-text"></div>
+	    </div>
+	  </div>
 	</div>

ws4kp.code-workspace

@@ -12,7 +12,8 @@
 			"**/bower_components": true,
 			"**/node_modules": true,
 			"**/vendor": true,
-			"dist/**": true
+			"dist/**": true,
+			"package-lock.json": true,
 		},
 		"cSpell.enabledFileTypes": {
 			"markdown": true,
@@ -76,7 +77,8 @@
 			"source.fixAll.eslint": "explicit"
 		},
 		"cSpell.words": [
-			"hibyehihi"
+			"hibyehihi",
+			"zakj"
 		]
 	},
 	"extensions": {