refactor(main.ts): improve code readability by adding conditional check for ijs length before initializing stage or collection

fix(resources.ts): handle case when imagesJson element is not found to prevent error and return empty array
This commit is contained in:
Sped0n
2023-10-30 15:54:36 +08:00
parent f328d727d5
commit ead0a84ac7
2 changed files with 12 additions and 7 deletions

View File

@@ -16,10 +16,12 @@ initState(ijs.length)
initNav()
if (!isMobile()) {
initStage(ijs)
initStageNav()
} else {
initCollection(ijs)
initGallery(ijs)
if (ijs.length > 0) {
if (!isMobile()) {
initStage(ijs)
initStageNav()
} else {
initCollection(ijs)
initGallery(ijs)
}
}

View File

@@ -9,7 +9,10 @@ export interface ImageJSON {
}
export function initResources(): ImageJSON[] {
const imagesJson = document.getElementById('imagesSource') as HTMLScriptElement
const imagesJson = document.getElementById('imagesSource')
if (!imagesJson) {
return []
}
return JSON.parse(imagesJson.textContent as string).sort(
(a: ImageJSON, b: ImageJSON) => {
if (a.index < b.index) {