refactor(state.ts): extract logic to get threshold session index into a separate function for reusability and clarity

This commit is contained in:
Sped0n
2023-11-04 19:36:19 +08:00
parent 90aa1ad480
commit b9dc117fd8
3 changed files with 25 additions and 8 deletions

View File

@@ -21,10 +21,8 @@ const thresholds = [
const defaultState = {
index: -1,
length: 0,
threshold:
thresholds[parseInt(sessionStorage.getItem('thresholdsIndex') || '2')].threshold,
trailLength:
thresholds[parseInt(sessionStorage.getItem('thresholdsIndex') || '2')].trailLength
threshold: thresholds[getThresholdSessionIndex()].threshold,
trailLength: thresholds[getThresholdSessionIndex()].trailLength
}
export const state = new Watchable<State>(defaultState)
@@ -75,7 +73,7 @@ export function decThreshold(): void {
*/
function updateThreshold(state: State, inc: number): State {
let i = thresholds.findIndex((t) => state.threshold === t.threshold) + inc
const i = thresholds.findIndex((t) => state.threshold === t.threshold) + inc
// out of bounds
if (i < 0 || i >= thresholds.length) return state
// storage the index so we can restore it even if we go to another page
@@ -83,3 +81,9 @@ function updateThreshold(state: State, inc: number): State {
const newItems = thresholds[i]
return { ...state, ...newItems }
}
function getThresholdSessionIndex(): number {
const s = sessionStorage.getItem('thresholdsIndex')
if (s === null) return 2
return parseInt(s)
}